On Tue, 30 May 2017 08:13:38 +0200 Anton Khirnov <[email protected]> wrote:
> Quoting Luca Barbato (2017-05-29 15:31:34) > > On 5/29/17 2:43 PM, wm4 wrote: > > > On Mon, 29 May 2017 13:59:40 +0200 > > > Luca Barbato <[email protected]> wrote: > > > > > >> --- > > >> avtools/avconv.c | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/avtools/avconv.c b/avtools/avconv.c > > >> index 719d289ff9..c30e1953ed 100644 > > >> --- a/avtools/avconv.c > > >> +++ b/avtools/avconv.c > > >> @@ -1127,14 +1127,14 @@ static void do_streamcopy(InputStream *ist, > > >> OutputStream *ost, const AVPacket *p > > >> int64_t ost_tb_start_time = av_rescale_q(start_time, > > >> AV_TIME_BASE_Q, ost->mux_timebase); > > >> AVPacket opkt; > > >> > > >> + av_init_packet(&opkt); > > >> + > > >> // EOF: flush output bitstream filters. > > >> if (!pkt) { > > >> output_packet(of, &opkt, ost, 1); > > >> return; > > >> } > > >> > > >> - av_init_packet(&opkt); > > >> - > > >> if ((!ost->frame_number && !(pkt->flags & AV_PKT_FLAG_KEY)) && > > >> !ost->copy_initial_nonkeyframes) > > >> return; > > > > > > This doesn't initialize all AVPacket fields. > > > > I can throw in a { 0 } if you like it better :) > > Stab. It's not a question of "liking", there are correct things to do > and incorrect things to do. So do the correct thing. > Indeed, it's a necessity, or you'll get just as much UB as before. It's not just a style or other minor issue. Maybe I should have mentioned it. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
