On Wed, 31 May 2017, Hendrik Leppkes wrote:

On Wed, May 31, 2017 at 6:29 PM, Rémi Denis-Courmont <[email protected]> wrote:
Le keskiviikkona 31. toukokuuta 2017, 12.30.34 EEST Diego Biurrun a écrit :
On Wed, May 31, 2017 at 01:21:42PM +0300, Martin Storsjö wrote:
> This makes the getaddrinfo functions visible, which aren't normally
> by default on legacy mingw.
>
> We already force __MSVCRT_VERSION__ to an XP version.
> ---
>
>  configure | 2 ++
>  1 file changed, 2 insertions(+)

probably OK

You could mention in the log message what 0x0501 stands for (XP?).

There are macros defining the useful values. For this specific case,
_WIN32_WINNT_WINXP exists.


If you want to use a macro, then use _WIN32_WINNT_WS03, which is the
one that corresponds to 0x0502 (XP SP2 or Server 2003 SP1)

Kept the numeric constant for consistency with the other cases of the same in configure, pushed with the other comments applied.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to