On Wed, Jun 07, 2017 at 04:50:43PM +0200, wm4 wrote: > On Wed, 7 Jun 2017 16:41:21 +0200 Diego Biurrun <[email protected]> wrote: > > > On Tue, Jun 06, 2017 at 06:51:11PM +0200, wm4 wrote: > > > --- a/configure > > > +++ b/configure > > > @@ -4673,6 +4682,7 @@ check_builtin stdatomic_h stdatomic.h "atomic_int > > > foo; atomic_store(&foo, 0)" > > > check_lib shell32 "windows.h shellapi.h" CommandLineToArgvW -lshell32 > > > check_lib wincrypt "windows.h wincrypt.h" CryptGenRandom -ladvapi32 > > > check_lib psapi "windows.h psapi.h" GetProcessMemoryInfo -lpsapi > > > +check_lib ole32 "windows.h" CoTaskMemFree -lole32 > > > > This looks like a stray change. Probably belongs in 1/6. > > Uh, no.
In 1/6 you add a reference to ole32, here you add the check. When I mentioned that the (empty) reference to ole32 in 1/6 looked shady in 1/6 you insisted that it's correct, I should read the C code. Now you insist that it belongs in 5/6. Both statements contradict each other, please make up your mind. I am working on a tree with these issues fixed locally. I can only finish it once this is settled. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
