On Mon, Jun 19, 2017 at 03:52:46PM +0300, Martin Storsjö wrote: > The rtmp protocol uses nonblocking reads, to poll for incoming > messages from the server while publishing a stream. Prior to > 94599a6de3822b13c94096d764868128f388ba28 and > d13b124eaf452b267480074b2e6946538ed03a6e, the tls protocol > handled the nonblocking flag.
Those commit logs claim that the tls protocol does not have to handle the nonblocking flag, apparently it has to now. An explanation would be illuminating. probably OK > --- a/libavformat/tls_gnutls.c > +++ b/libavformat/tls_gnutls.c > @@ -97,7 +98,10 @@ static ssize_t gnutls_url_pull(gnutls_transport_ptr_t > transport, > return ret; > if (ret == AVERROR_EXIT) > return 0; > - errno = EIO; > + if (ret == AVERROR(EAGAIN)) > + errno = EAGAIN; > + else > + errno = EIO; > return -1; > } > > @@ -110,7 +114,10 @@ static ssize_t gnutls_url_push(gnutls_transport_ptr_t > transport, > return ret; > if (ret == AVERROR_EXIT) > return 0; > - errno = EIO; > + if (ret == AVERROR(EAGAIN)) > + errno = EAGAIN; > + else > + errno = EIO; > return -1; > } Convert to switch/case at some point? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
