On Thu, 29 Jun 2017 14:44:52 -0400 Vittorio Giovara <vittorio.giov...@gmail.com> wrote:
> On Thu, Jun 29, 2017 at 5:18 AM, wm4 <nfx...@googlemail.com> wrote: > > On Wed, 28 Jun 2017 18:10:56 -0400 > > Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > > > >> Since the request_channel_layout is used only by a handful of codecs, > >> move the option to codec private contexts. > > > > Not sure if that is justified... > > I believe it is always good to move options out of the global state, > and this seems to be a perfect opportunity: beside adding the new API, > we are modifying the concept that a channel layout is not represented > (simply) by a bitmask, but by a series of features, such as map, > channel order, and count. The request_channel_layout is the last > holdout of that concept, so I think it makes sense to change and allow > for future expansion, for example an in-codec downmix from ambisonic > to normal stereo. +1 for less global state, -1 to more AVOption API _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
