On Sat, Jun 24, 2017 at 5:48 PM, Diego Biurrun <[email protected]> wrote: > On Sat, Jun 24, 2017 at 11:56:07AM -0300, James Almer wrote: >> On 6/23/2017 8:39 PM, Mark Thompson wrote: >> > --- a/libavcodec/h264.h >> > +++ b/libavcodec/h264.h >> > @@ -44,4 +44,49 @@ enum { >> > + >> > +enum { >> >> enum seems like a weird choice for this to be honest. Same with the >> following patch. >> >> What's wrong with using #define?
I only saw this in the latest batch of the patch, so sorry for the late reply, and I found the use of an anonymous enum quite weird. > > Why would you want to use #defines when you can use an enum? What's wrong > with type safety? :) > There is no type safety here, since the type has no name. I didn't see any reason to prefer the enum, only why it isn't necessary to use a define. It smells quite odd to me, and unlike anything we use anywhere else. So whats the reasoning to use those? - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
