On Fri, Jul 21, 2017 at 10:08:15AM +0800, Huang, Zhengxu wrote:
>
>
> On 2017/7/20 20:07, Diego Biurrun wrote:
> > On Wed, Jul 19, 2017 at 02:41:31PM +0800, Huang, Zhengxu wrote:
> > > --- a/libavcodec/qsvenc.c
> > > +++ b/libavcodec/qsvenc.c
> > > @@ -568,6 +627,24 @@ FF_ENABLE_DEPRECATION_WARNINGS
> > > +static int qsv_retrieve_enc_jpeg_params(AVCodecContext *avctx,
> > > QSVEncContext *q)
> > > +{
> > > + int ret = 0;
> > > +
> > > + ret = MFXVideoENCODE_GetVideoParam(q->session, &q->param);
> > pointless initialization
> In my opinion maybe keep this code much better in case the QSV MSDK modify
> mjpeg code logic in the later release.
I have seen code waiting more than ten years for some future change in
external libraries. It's better to modify code when the time comes than
wait in vain ;)
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
