On 20/09/17 19:48, Diego Biurrun wrote:
> On Sun, Sep 10, 2017 at 12:09:13AM +0100, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/tests/fate/cbs.mak
>> @@ -0,0 +1,74 @@
>> +
>> +define FATE_CBS_TEST
>> +# (codec, test_name, sample_file, output_format)
>> +FATE_CBS_$(1) += fate-cbs-$(1)-$(2)
>> +fate-cbs-$(1)-$(2): CMD = md5 -i $(TARGET_SAMPLES)/$(3) -c:v copy -bsf:v 
>> $(1)_metadata -f $(4)
>> +endef
>> +
>> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
>> +
>> +$(foreach N,$(FATE_CBS_HEVC_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,hevc,$(basename $(N)),hevc-conformance/$(N),hevc)))
> 
> The 1st and 4th arguments are identical. If you wanted, you could get rid
> of the prefix of the third argument by integrating it into CMD.

Further down the file there is also:

>> +$(foreach N,$(FATE_CBS_MPEG2_SAMPLES),$(eval $(call 
>> FATE_CBS_TEST,mpeg2,$(basename $(N)),mpeg2/$(N),mpeg2video)))

which doesn't admit either of those changes.

Thanks,

- Mark
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to