On Wed, Oct 11, 2017 at 05:45:05PM +0200, Hendrik Leppkes wrote:
> On Wed, Oct 11, 2017 at 5:44 PM, Diego Biurrun <[email protected]> wrote:
> > On Wed, Oct 11, 2017 at 05:33:29PM +0200, Diego Biurrun wrote:
> >> On Wed, Oct 11, 2017 at 09:17:56AM +0200, Hendrik Leppkes wrote:
> >> > On Wed, Oct 11, 2017 at 12:58 AM, Diego Biurrun <[email protected]> wrote:
> >> > > --- a/configure
> >> > > +++ b/configure
> >> > > @@ -925,13 +925,15 @@ check_stripflags(){
> >> > >
> >> > >  check_header(){
> >> > >      log check_header "$@"
> >> > > -    header=$1
> >> > > +    headers=$1
> >> >
> >> > Wouldn't $1 only be the first header passed, not the list?
> >>
> >> Not if you quote the list, which is what I do here and what we do in other
> >> similar cases.
> >
> > Correction: which is what I stupidly forgot to do here. Thanks for the 
> > catch.
> 
> Considering the function doesn't take any other parameters, wouldnt it
> be easier to just take all arguments without the need for quoting?

Yes, but I'll leave it as first parameter so it remains possible to pass
some extra flags to the compiler invocation.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to