Hi Hendrik,

On Nov 2, 2017 4:21 AM, "Hendrik Leppkes" <h.lepp...@gmail.com> wrote:

On Thu, Nov 2, 2017 at 3:10 AM, Sean McGovern <gsean...@gmail.com> wrote:
> ---
>  libavformat/matroskadec.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index c6e1a19..3743d4d 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -1606,6 +1606,10 @@ static int mkv_parse_video_projection(AVStream
*st, const MatroskaTrack *track)
>      int ret;
>      GetByteContext gb;
>
> +    if (track->video.stereo_mode == MATROSKA_VIDEO_STEREOMODE_TYPE_NB) {
> +       return 0;
> +    }
> +

Stereo-mode seems a bit unrelated to the projection, additionally
comparing to the _NB constant seems wrong, it should never be that
value.


The sample file in question predates both stereo mode and spherical video
streams and yet currently it triggers the log warning:

Unknown spherical metadata type 0

from the default: clause of the switch statement further down in this
function.

Thinking about this it probably shouldn't even be calling this function at
all in this situation. Will look at it again and propose a new patch.

Please consider this one dropped for now.


_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


-- Sean McG.
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to