On 10/11/17 12:29, Diego Biurrun wrote:
> On Thu, Nov 09, 2017 at 01:07:49AM +0000, Mark Thompson wrote:
>> --- a/libavcodec/cbs_mpeg2.c
>> +++ b/libavcodec/cbs_mpeg2.c
>> @@ -54,7 +54,7 @@
>>
>> #define marker_bit() do { \
>> - av_unused int one = 1; \
>> + av_unused uint32_t one; \
>> CHECK(ff_cbs_read_unsigned(ctx, rw, 1, "marker_bit", &one, 1, 1)); \
>
> Dropping the initialization looks odd. Also, why is this av_unused?
It's only written and the value discarded - it must be 1, after all. (Any
static analysis which looks inside ff_cbs_read_unsigned() will be able to
complain that it isn't used.)
- Mark
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
