On 10/11/17 12:31, Diego Biurrun wrote: > On Thu, Nov 09, 2017 at 01:07:50AM +0000, Mark Thompson wrote: >> --- a/libavcodec/cbs_h2645.c >> +++ b/libavcodec/cbs_h2645.c >> @@ -824,6 +824,7 @@ static int cbs_h264_read_nal_unit(CodedBitstreamContext >> *ctx, >> err = cbs_h264_read_sei(ctx, &bc, sei); >> if (err < 0) { >> cbs_h264_free_sei(sei); >> + av_free(sei); >> return err; >> } > > Looks OK, but it's confusing to see free_foo(foo) not free foo ...
Yeah, all the freeing stuff is rather complex here. I have plans to replace all of the pointer tracking with bufferrefs, such that every free operation is just av_buffer_unref() and we don't have the trickery to distinguish between externally- and internally-allocated blocks. Thanks, - Mark _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel