On Sun, Feb 11, 2018 at 11:35:36PM -0300, James Almer wrote:
> On 2/11/2018 4:09 PM, Diego Biurrun wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -1097,11 +1097,9 @@ check_struct(){
> >  check_builtin(){
> >      log check_builtin "$@"
> >      name=$1
> > -    headers=$2
> > -    builtin=$3
> > -    shift 3
> > +    shift
> >      disable "$name"
> > -    check_code ld "$headers" "$builtin" "$@" && enable "$name"
> > +    check_code ld "$@" && enable "$name"
> >  }
> >  
> >  check_compile_assert(){
> > @@ -1118,25 +1116,20 @@ require(){
> >      log require "$@"
> >      name_version="$1"
> >      name="${1%% *}"
> > -    headers="$2"
> > -    func="$3"
> > -    shift 3
> > -    check_lib $name "$headers" $func "$@" || die "ERROR: $name_version not 
> > found"
> > +    shift
> > +    check_lib $name "$@" || die "ERROR: $name_version not found"
> >  }
> >  
> >  require_header(){
> >      log require_header "$@"
> >      headers="$1"
> > -    shift
> > -    check_header "$headers" "$@" || die "ERROR: $headers not found"
> > +    check_header "$@" || die "ERROR: $headers not found"
> >  }
> >  
> >  require_cpp_condition(){
> >      log require_cpp_condition "$@"
> > -    header="$1"
> >      condition="$2"
> > -    shift 2
> > -    check_cpp_condition "$header" "$condition" "$@" || die "ERROR: 
> > $condition not satisfied"
> > +    check_cpp_condition "$@" || die "ERROR: $condition not satisfied"
> >  }
> 
> Does passing "$@" keep and propagate the arguments split in a way
> check_code() and similar can properly identify and handle? Checks can
> use more than one header after all.

Yes. Notice that we rely on that behavior even before this patch.

Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to