> > Hi, I thought the library user would like to have a separate writer_id > since I assumed that the identifier is used for logging and resource > accounting purposes (e.g. browsers using this backend might want to use > a separate identifier per-tab). > > The common options pattern is used when there are multiple codecs > relying on the same backend. I would expect to have the common options > expanded instead of dropped, what are your plans exactly? > > lu >
Hi, 1) AMFTraceWriter is abstraction to configure how AMF outputs its logs for current process, not for component. Example instances of AMFTraceWriter can be * FileWriter * SocketWriter * DebugOutputWriter * LibavWriter (output using av_log function). AMFTraceWriter can be Registered/Unregistered/Enabled/Disabled and configured to output particular level of trace output. If we use multiple LibavWriter objects in one process, we will have duplication of output in avlib log. To prevent this scenario we should use one constant writer_id . 2) AMF_COMMON_OPTIONS in header. It is more about balance between preventing duplication and code readability and visibility. IMHO minor duplication is less important than core readability and visibility. I'd recommend to have property map for each component in one place. ________________________________ This e-mail and any attachment(s) are intended only for the recipient(s) named above and others who have been specifically authorized to receive them. They may contain confidential information. If you are not the intended recipient, please do not read this email or its attachment(s). Furthermore, you are hereby notified that any dissemination, distribution or copying of this e-mail and any attachment(s) is strictly prohibited. If you have received this e-mail in error, please immediately notify the sender by replying to this e-mail and then delete this e-mail and any attachment(s) or copies thereof from your system. Thank you. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
