On Thu, 21.08.08 00:58, Lennart Poettering ([EMAIL PROTECTED]) wrote: > > On Wed, 20.08.08 16:53, Joe Marcus Clarke ([EMAIL PROTECTED]) wrote: > > > This adds the necessary error checking, and fixes the s/alsa/oss/ > > problem in configure.ac.
OK, merged now: http://git.0pointer.de/?p=libcanberra.git;a=commitdiff;h=d7d6d26e1f858841f333264a07edc512066269af I did a few more changes before actually commiting this: - added sys/param.h to includes, since that's where __BYTE_ORDER is defined. - Actually use __BYTE_ORDER instead of _BYTE_ORDER since the latter is not existant on most Unixes - Add missing check if number of channels are actually available - Fix a few warnings - Handle poll() returning something that is not POLLOUT for the audio device - Fix some cases where some functions where returning errno-style error codes, where they should be returning CA_ERROR_xxx error codes Also, the patch was against some mixed up tree, where part of the strndup was already applied and part was not? Please submit patches always based on upstream git, or at least some other well-defined sound consistent snapshot. Anyway. Everything seems fine now. I only compile-tested this, though. Could you please check if the new git master works for you on FreeBSD? Thanks, Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net ICQ# 11060553 http://0pointer.net/lennart/ GnuPG 0x1A015CC4 _______________________________________________ libcanberra-discuss mailing list [email protected] https://tango.0pointer.de/mailman/listinfo/libcanberra-discuss
