Robert William Fuller wrote:
Eric Shattow wrote:
Would you suggest removing it or making it configurable at run-time?
I would remove it. The cd-paranoia included with libcdio already has a
read offset correction option (-O). Similarly, my own ripper, cued,
does read offset correction as well. It is easy enough for the
application programmer to do read offset correction.
If we make it configurable, then we need to add it to NRG and all the
other drivers as well. Adding it to the operating system drivers will
be a real pain because then we have to apply an offset across sector
boundaries, which means reading additional sectors. This is best done
at a higher level, like the application level, which is how libcdio's
cd-paranoia and cued manage it.
The most painless fix is to not change the model, but fix the bug. Even
if in the long term it is decided to change the model, the bug needs to
be fixed in the short term. By the way, it looks like the cdrdao driver
also has a 272 byte offset, probably for the same reason the bincue
driver has it.
One last thought on this.... While adding audio read offset correction
to the library might make sense for the operating system drivers, it
does not make sense for image files, unless the user happens to know the
read offset for the drive that created the image file. Even in the
unlikely event they happen to know it, they can always correct it with
the -O option to libcdio's cd-paranoia. From that perspective, it
definitely makes sense to simply remove the 272 byte offset from
bincue.c and cdrdao.c.
