These changes seem reasonable to me, although I don't really understand patch 1 and don't have a way to test on FreeBSD.
So I ask others to look over and comment on. The usual silence after a reasonable period of time will be taken to mean agreement that this should be committed and it will be done. I was planning a release around Oct 27, but I also will solicit comments as to whether this should go into that release or not. On Mon, Oct 19, 2009 at 6:20 PM, Geoff Bailey <[email protected]> wrote: > I have attached a couple of patches that fix the FreeBSD IOCTL interface in > libcdio. > > 1. The patch "patch-lib_driver_FreeBSD_freebsd_ioctl.c" fixes the > read_audio_sectors_freebsd_ioctl() function. > > 2. The patch "patch-lib_driver_FreeBSD_freebsd.c" resets the 'exists' > variable to true before scanning for ATAPI devices and adds a function to > set the default access mode. This is required when enumerating devices with > "cdio_get_devices_with_cap", since one is unable to set the access mode in > this case and it defaults to CAM. > > Since the ATAPI driver is in the GENERIC FreeBSD kernel and the ATPICAM > driver must be loaded manually, these changes make libcdio work immediately > upon installation. > > Also, my older model drive fails with "xmms2" (when using the CAM > interface) with "transport failed" but the IOCTL interface works. > >
