On Mon, Jan 30, 2012 at 9:36 PM, Rocky Bernstein <[email protected]> wrote:
> On Mon, Jan 30, 2012 at 8:47 AM, Pete Batard <[email protected]> wrote: > >> On 2012.01.30 02:22, Rocky Bernstein wrote: >> >>> Removing the requirement cdio_config.h is probably okay. However removing >>> it ultimately from the distribution is a little bit different. >>> >>> The file serves to document how libcdio was compiled. So as such I think >>> it >>> should remain. Also I'm a little concerned about compatibility and so >>> again, if a program had been using this, although we may decide to >>> deprecate it, that is different from removing it. >>> >> >> Good point. I hadn't thought of that, and I agree that keeping a copy of >> the config is something we want. >> >> I'll add a commit that restores the copying of config.h to >> include/cdio/cdio_config.h >> >> I don't think cdio_unconfig.h needs to be restored though - do you see it >> differently? > > > I think what really needed is a transformation of config.h which > prepends, say CDIO_ to a number of the defines like the PACKAGE* defines > and other defines like _FILE_OFFSET_BITS, _LARGEFILE_SOURCE and > WORDS_BIGENDIAN. With this, such a modified header can be included safely > in other programs that want to test or or present the features of the > libcdio that gets used. > It turns out this is basically changing one line: a "cat" to "sed" in include/cdio/Makefile.am. A patch is attached to the pbatard trunk. (I haven't applied it.) I tried to do this in the main branch, but because cdio_config.h is needed by cdio.h it fails miserably.
