On Sat, 2 Apr 2016 21:52:50 -0400 Rocky Bernstein <[email protected]> wrote:
> But I would like the commit message to be something better than: > Fix incorrect parsing of CD-Text with short fields > > As best as I can tell from reading the code, when a particular loop > has to iterated more than once we need to also increase the track > number. Is that right? If so, none of that seems reflected by that > commit message. True. But it also fixes the (CD-Text related part of the) bug reported by James Olin Oden. How about: fix: track number was not increased after parsing short CD-Text fields > Finally, if you want me or others to look over patches (with a good > level of precision), the most error prone way is to do it via cutting > and pasting from list archives. The best would be just to do what I > did: create a branch in libcdio and apply the change. If git isn't > your thing, then submit the patch via > https://savannah.gnu.org/patch/?func=additem&group=libcdio Will do. Thanks. There are a few more fixes on the way. Regards Leon
