Hi, the cd-paranoia commits look correkt to me. But i have a long term clarity objection and believe to see the insertion of an unreachable piece of code.
------------------------------------------------------------------------- https://github.com/vext01/libcdio-paranoia/commits/start-track-num-not-one - 9d2cf9f1d3573a7d3d38c245f558b9b0f34afb9d "Track numbers may not start at one." (Some objections) ----------------------------------------------------------------------- This gesture in lib/cdda_interface/toc.c is now counter-intuitive: for (i = first_track - 1; i < first_track - 1 + d->tracks; i++) if( cdda_track_audiop(d, i+1)==1 ) { if (i == first_track - 1) /* disc starts at lba 0 if first track is an audio track */ return 0; else return cdda_track_firstsector(d, i+1); } "i" once iterated as toc[] index and deduced the track number as "i+1". This index idea was wrong and is gone now. But "first_track - 1" and the compensating "i+1" remain and let the reader riddle. I'd change them to "first_track" and "i". ----------------------------------------------------------------------- What is the reason for this gesture in src/cd-paranoia.c : report("Selected span contains non audio track at track %02d. Aborting.\n\n", i); exit(1); if (i == 0) i = cdio_get_first_track_num(d->p_cdio) - 1; Isn't the code after exit(1) unreachable ? ----------------------------------------------------------------------- - 3d1fb61cd5474026f947666f44c7ad0d156747c6 "OpenBSD: Make autogen.sh work. " (OK) - 28429e919451d9ba3b6a8946cdeee9a80ddbd502 "Fix the display of tracks by cd-paranoia for CDs with start track >1." OK (biased as i am) - d7cafd07b9fc736790f000730b6382e626e366c9 "Fix endianess detection for CDs with starting track >1." OK (biased) Have a nice day :) Thomas
