On Thu, Dec 18, 2008 at 06:24:44PM +0530, Sudhir Kumar wrote: > The following patch fixes the defect #2338181 on sourceforge.net. > However this is not the updated fix, but it helps in running the > test as the fix will be merged in the next release. >
I will keep this patch on hold for now, as I study the implication of exposing this API. Apart from that, this patch is wrong for the reasons I have mentioned later on. > Signed-off-by: Sudhir Kumar <[email protected]> > > Index: trunk/libcgroup.h > =================================================================== > --- trunk.orig/libcgroup.h > +++ trunk/libcgroup.h > @@ -217,6 +217,8 @@ int cgroup_set_uid_gid(struct cgroup *cg > uid_t control_uid, gid_t control_gid); > int cgroup_get_uid_gid(struct cgroup *cgroup, uid_t *tasks_uid, > gid_t *tasks_gid, uid_t *control_uid, gid_t *control_gid); > +struct cgroup_controller *cgroup_get_controller(struct cgroup *cgroup, > + const char *name); > int cgroup_get_value_string(struct cgroup_controller *controller, > const char *name, char **value); > int cgroup_set_value_string(struct cgroup_controller *controller, > Index: trunk/libcgroup.map > =================================================================== > --- trunk.orig/libcgroup.map > +++ trunk/libcgroup.map > @@ -23,6 +23,7 @@ global: > cgroup_compare_controllers; > cgroup_set_uid_gid; > cgroup_get_uid_gid; > + cgroup_get_controller; We do not add it in the older releases. If added, it will only be in the newer releases. This will break ABI compatibility. > cgroup_get_value_string; > cgroup_set_value_string; > cgroup_get_value_int64; > -- regards, Dhaval ------------------------------------------------------------------------------ _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
