On Mon, Dec 22, 2008 at 10:56:35PM +0530, Sudhir Kumar wrote:
> This set of patches creates the functions for testing each api.
> This set addresses all the comments accepted in the previous post.
> 

Thanks merged.

Some comments to be noted,

1. Please give a more detailed changelog detailing the what the patch
does. For example, 

        This patch adds testcases for cgroup_add_controller() wrapper api.

does not really tell us what the patch does. The changelog should
consist of what the test does.

2. Coding style. checkpatch caught 2 warnings. While they are minor,
please take care in the future.

3. I do have some additional comments on some of the patches, I will
bring it up in a separate mail.


thanks,
-- 
regards,
Dhaval

------------------------------------------------------------------------------
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to