On Fri, Jan 02, 2009 at 09:38:40PM +0530, Balbir Singh wrote: > * Dhaval Giani <[email protected]> [2009-01-02 17:55:11]: > > > Pointers should be initialized to NULL. In the multi mount test case > > path, we had an uninitialized cgroup_filled which caused a > > segmentation fault. Fix it for this test case. > > > > TODO: > > Fix for all test cases. > > > > Signed-off-by: Dhaval Giani <[email protected]> > > Cc: Sudhir Kumar <[email protected]> > > > > --- > > tests/libcgrouptest01.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Index: trunk/tests/libcgrouptest01.c > > =================================================================== > > --- trunk.orig/tests/libcgrouptest01.c 2008-12-30 19:03:35.000000000 > > +0530 > > +++ trunk/tests/libcgrouptest01.c 2009-01-02 16:24:22.000000000 +0530 > > @@ -1321,8 +1321,8 @@ void test_cgroup_compare_cgroup(int ctl1 > > > > void test_cgroup_get_cgroup(int ctl1, int ctl2, int i) > > { > > - struct cgroup *cgroup_filled, *cgroup_a, *cgroup_b; > > - struct cgroup_controller *controller; > > + struct cgroup *cgroup_filled = NULL, *cgroup_a = NULL, *cgroup_b = NULL; > > + struct cgroup_controller *controller = NULL; > > char controller_name[FILENAME_MAX], control_file[FILENAME_MAX]; > > int ret; > > This seems like a critical fix >
Yep, without this fix we cannot run the test cases, I will merge this in right now. > Acked-by: Balbir Singh <[email protected]> > > -- > Balbir -- regards, Dhaval ------------------------------------------------------------------------------ _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
