* Dhaval Giani <[email protected]> [2009-01-05 00:07:33]: > Hi, > > How does the following look? > > Thanks, > > libcgroup: Fix low hanging cleanups > > Some of the cleanups possible are obvious. > 1. Change usage of strcat to strncat > 2. Change usage of tge following type > char *s = malloc(); > strcpy(s, "somestring"); > strcat(s, "someotherstring"); > > to something more easily understandble such as > asprintf(&s, "%s%s", somestring, someotherstring); > Changes for v2: > 1. Fix some memory leaks discovered using valgrind > 2. Fix Balbir's comments regarding codingstyle. > 3. Move the controllers array memory leak fix into another patch > Changes from v1: > 1. Correct the error handling of asprintf as pointed out by Dan Smith > > TODO: > 1. Figure out what is the correct value of n for cg_build_path_locked >
Looks ok but too many changes for my comfort. I am glad it has been tested well Acked-by: Balbir Singh <[email protected]> -- Balbir ------------------------------------------------------------------------------ _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
