On Tue, Jan 06, 2009 at 03:20:31PM +0530, Sudhir Kumar wrote: > On Tue, Jan 06, 2009 at 02:20:18PM +0530, Dhaval Giani wrote: > > On Mon, Jan 05, 2009 at 08:47:05PM +0530, Balbir Singh wrote: > > > * Dhaval Giani <[email protected]> [2009-01-05 00:07:33]: > > > > > > > Hi, > > > > > > > > How does the following look? > > > > > > > > Thanks, > > > > > > > > libcgroup: Fix low hanging cleanups > > > > > > > > Some of the cleanups possible are obvious. > > > > 1. Change usage of strcat to strncat > > > > 2. Change usage of tge following type > > > > char *s = malloc(); > > > > strcpy(s, "somestring"); > > > > strcat(s, "someotherstring"); > > > > > > > > to something more easily understandble such as > > > > asprintf(&s, "%s%s", somestring, someotherstring); > > > > Changes for v2: > > > > 1. Fix some memory leaks discovered using valgrind > > > > 2. Fix Balbir's comments regarding codingstyle. > > > > 3. Move the controllers array memory leak fix into another patch > > > > Changes from v1: > > > > 1. Correct the error handling of asprintf as pointed out by Dan Smith > > > > > > > > TODO: > > > > 1. Figure out what is the correct value of n for cg_build_path_locked > > > > > > > > > > Looks ok but too many changes for my comfort. I am glad it has been > > > tested well > > > > > > Acked-by: Balbir Singh <[email protected]> > > > > > > > Thanks balbir, I have merged this patch. After this patch, we have > > reduced the valgrind issues to 0 for the library as per the libcgroup > > test suite. > > > > I will run it other scenarios to see how it looks there. > > > > Also it might be a good time to get the coverage data of the tests. > Basicaly I was working on it and dont know how I was not able to linkt > to the proper libraries due to some makefile corruption. i will work on > the same again and report the results soon.
Yep, I just started going through the man pages of gcc to get the coverage information and learn the whole process. thanks, -- regards, Dhaval ------------------------------------------------------------------------------ _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
