On Thu, Jan 08, 2009 at 12:29:05PM +0530, Sudhir Kumar wrote:
> On Thu, Jan 08, 2009 at 12:10:19AM +0530, Dhaval Giani wrote:
> > On Wed, Jan 07, 2009 at 10:20:35PM +0530, Sudhir Kumar wrote:
> > > This patch adds comments on some variables which were causing compiler
> > > warnings as they were not being used. Also there was a risk of ret being
> > > used uninitialized.
> > >
> > > Signed-off-by: Sudhir Kumar <[email protected]>
> > >
> >
> > NAK. Also, the ret change belongs to another patch. (Can you send it
> > separately so I can merge it in)
> So what do you say on Steve's comments?
I like those. Let's do it that way.
> >
> > (NAK because those variable are used for the part that is commented out)
> Even if the comments are removed there is a risk that ret may be used
> uninitialized.
That's a different patch altogether :-)
> Other thing the commented part is using C99 comments which is very bad.
> No idea how it got merged in trunk.
> >
> > > ---
> > > tests/setuid.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > Index: trunk/tests/setuid.c
> > > ===================================================================
> > > --- trunk.orig/tests/setuid.c
> > > +++ trunk/tests/setuid.c
> > > @@ -35,13 +35,13 @@ int main(int argc, char *argv[])
> > > uid_t uid;
> > >
> > > /* Group data */
> > > - struct group *grp;
> > > +/* struct group *grp; */
> > >
> > > /* GID of group */
> > > - gid_t gid;
> > > +/* gid_t gid; */
> > >
> > > /* Return codes */
> > > - int ret;
> > > + int ret = -1;
> > >
> > > if (argc < 2) {
> > > printf("Usage: %s <uid_value> \n", argv[0]);
> > >
> >
> > --
> > regards,
> > Dhaval
>
> --
> Regards
> Sudhir Kumar
> Linux Technology Center
> IBM, India.
--
regards,
Dhaval
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
