On Mon, Feb 09, 2009 at 12:33:25PM +0530, Dhaval Giani wrote:
> On Fri, Feb 06, 2009 at 03:19:16PM +0100, Jan Safranek wrote:
> > I've rewritten cgrulesengd to behave more like standard daemon.
> >
> > Now it's possible to:
> > - Set log destination - syslog, log file or both. Syslog (DAEMON facility)
> > is
> > default.
> > - Set log level. By default, only errors, startup, shutdown and config
> > reload
> > are logged.
> > - Set syslog facility ('D' for DAEMON, '0'-'7' for LOCAL0-LOCAL7, more can
> > be
> > added).
> > - Start daemon in 'debug' mode using one option (maximum log level, don't
> > fork the daemon).
> >
> > Whole logging and command line parsing has been rewritten. There is whole
> > new
> > set of command line options, old options do not work (it wouldn't be that
> > hard
> > to support them if you insist...).
> >
>
> Hi Jan,
>
> I haven't yet looked at the patches, and will take a look at them soon.
> I would think that we would want the old options to work.
>
OK, so a couple comments,
1. Please split up the patches logically. A patch should try to do one
thing at a time. I would normally expect to see part of patch1 and
patch3 together.
2. Each patch should be compilable individually.
In general, I like the changes. However, we do need to support the older
options. Can you please send a v2 with these changes, so that we
can have a much closer review and look at merging these patches in?
Thanks,
--
regards,
Dhaval
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
