On Fri, Feb 20, 2009 at 08:28:43PM +0530, Balbir Singh wrote: > * Dhaval Giani <[email protected]> [2009-02-20 12:59:38]: > > > On Fri, Feb 20, 2009 at 09:37:20AM +0530, Balbir Singh wrote: > > > > > > From: Balbir Singh <[email protected]> > > > > > > cgroup_create_cgroup() can return -1, which causes cgroup_strerror() to > > > assert. This patch fixes that problem and another one where we incorrectly > > > return -1 if we fail to open /proc/mounts. We should return 0 there. > > > > > > The patch also fixes a potential security issue. We were freeing path > > > and using asprintf, but path is set to fts_path[0], which we use for > > > changing permissions recursively. I don't understand why that was done or > > > why we use asprintf there in the first place. > > > > Can you please split this patch into two (or three), there are too many > > things happening in it. :( > > [snip] > > How does this look? >
Thanks balbir! Merged it in! -- regards, Dhaval ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
