On Wed, Mar 25, 2009 at 09:13:54AM +0100, Ivana Varekova wrote:
> Thanks for the comment.
> 
> If cgconfig.conf file is empty, there should be no error message if we
> start cgconfig service.

I am not sure why there should be no error message.

> Attached patch fixes this problem. 
> 
> Signed-off-by: Ivana Varekova <[email protected]>
> ---
> 
>  0 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/config.c b/config.c
> index b188985..fadfa64 100644
> --- a/config.c
> +++ b/config.c
> @@ -477,7 +477,7 @@ int cgroup_config_load_config(const char *pathname)
>               goto err_mnt;
> 
>       error = cgroup_init();
> -     if (error)
> +     if ((error) && !((error == ECGROUPNOTMOUNTED) && (cgroup_table_index == 
> 0)))

This does not make sense to me. From what I can make out, if there is an
error, and not(the cgroup fs is  not mounteed and there is an empty config
file) we will fail. Why is cgroupfs not being mounted and having an
empty config file not a fail case?

thanks,
-- 
regards,
Dhaval

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to