Hi KAMEZAWA-san, Thank you for the comment.
KAMEZAWA Hiroyuki wrote: >>> This patchset adds a new rule based on process name. >>> I have some TODOS, so this patchset is not complete. >>> I'd like to talk about them, any comment is welcome. >>> >>> TODOS: >>> ====== >>> * The cgroup directory, which is specified by `cgexec` command, is >>> ignored because this patch adds an EXEC event to the event handler. >>> This problem should be fixed. >>> >>> * Think about the length of process name. >>> A process name is taken from /proc/<pid>/status file, and the name >>> is shortened to 15 characters if the real name is over than 16 >>> characters. That is a linux kernel's behavior. Should we consider >>> a process name in /etc/cgrules.conf as 15 characters, if it is over >>> than 16 characters like a linux kernel ? >>> >> I'm sorry that I don't read the whole patch precisely. >> >> Why based on "process name", why not "exec file" ? >> Do you have special reason ? > > One disadvantage of exe file I can think of is "script" file. > But /proc/xxx/status's information is too naive. > > Can't you parse /proc/xxx/cmdline file and check "what's really executed ?" > Parser can be very difficult ? Good point. We can parse /proc/xxx/cmdline instead of /proc/xxx/status for getting a process name, and that is better than current patch. But I have one concern. The /proc/xxx/cmdline file of a kernel thread is empty, and we cannot get the name from the file. How about getting a process name from a /proc/xxx/status file only if /proc/xxx/cmdline is empty ? Thanks Ken'ichi Ohmichi ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
