Hi Jan, Jan Safranek wrote: > Ken'ichi Ohmichi wrote: >> Hi, >> >> This patchset adds a new rule based on process name. >> I have some TODOS, so this patchset is not complete. >> I'd like to talk about them, any comment is welcome. >> >> TODOS: >> ====== >> * The cgroup directory, which is specified by `cgexec` command, is >> ignored because this patch adds an EXEC event to the event handler. >> This problem should be fixed. > > Not only this, your patchset changes semantic of pid in > cgroup_change_cgroup_uid_gid from 'change this process' to 'change this > process based on its process name'. If one has following cgrules.conf: > > *:cgexec cpu first > * cpu second > > and executes 'cgexec bash', the first rule is matched instead of the > second one - cgroup_change_cgroup_uid_gid is called with pid of cgexec. > Should there be a new flag in cgroup_change_cgroup_uid_gid_flags, which > would tell it not to use procname? Or use procname provided by caller > (i.e. cgexec would pass 'bash' in this case)?
Thank you for good point. I am worried of the coverage of a new rule based on process name. Do you think a new rule should not be applied to cgexec and cgclassify ? I feel it is better that a new rule is applied to all libcgroup tools, because the rule must be the same. What is the merit of a new flags in cgroup_change_cgroup_uid_gid_flags() ? Thanks Ken'ichi Ohmichi ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
