On 06/15/2009 05:21 PM, Dhaval Giani wrote:
> This API unloads the cgroupfs filesystem in memory. With this API
> we can now replace service cgconfig stop with a cgconfigparser -u
>

Wouldn't it be better to have separate utility, let's say 'cgclear', 
instead of 'cgconfigparser -u'? The 'cgconfigparser' name suggests, that 
it parses the config file and removes the groups which it finds there. 
But in reality, it just removes everything it finds, regardless if it is 
in the config or not.

And as Bharata pointed out, cgroup_config_unload_config is too long. 
IMHO separate cgroup_remove_group() could be helpful to other tools.


Jan

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to