* Dhaval Giani <[email protected]> [2010-02-18 15:38:20]:
> On Thu, Feb 18, 2010 at 3:30 PM, Balbir Singh <[email protected]>
> wrote:
> > * Dhaval Giani <[email protected]> [2010-02-18 15:05:48]:
> >
> >>
> >> libcgroup was not making an entry into the pkg-config database, which
> >> makes life easier when using multiple libraries. Add the needed data
> >> in order to be registered with the pkg-config database on installation.
> >>
> >> Signed-off-by: Dhaval Giani <[email protected]>
> >>
> >
> > Please look at my questions below, BTW, you mention the changelog as
> > 0.35.2, I'd rather we use 0.36.rc1-1 or so.
> >
>
> Actually, good point. I should have bumped up the version since we are
> already past v0.35. I will repost with those changes. (I think this
> also answers your question further ahead, and so I have deleted that
> part)
>
> [/me blames the late night for that mistake!]
>
:-) Even the other spec file change to 2 is answered by your comment
above?
> Thanks for the review!
>
> Can I add a "Reviewed-by" or "Acked-by" with those changes in?
>
Could you please make sure you build and run the library. After that
I'd be willing to ack it.
--
Three Cheers,
Balbir
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
