On Wed, Oct 6, 2010 at 1:50 PM, Ivana Hutarova Varekova <[email protected]> wrote: > On 10/06/2010 01:18 PM, Dhaval Giani wrote: >> >> Quick question, will do a closer review soon >> >> >>> >>> +#define BLACKLIST_CONF "/etc/cgsnapshot_blacklist.conf" >>> +#define WHITELIST_CONF "/etc/cgsnapshot_whitelist.conf" >>> >> >> Why do we have a default whitelist? >> >> Dhaval >> > > The default list was defined in the specification by jan, you have no option > agains it. > http://sourceforge.net/mailarchive/message.php?msg_name=AANLkTinMMaom23XbKxKQxHBdUK4q70oUdeb6U%3DEPaF7J%40mail.gmail.com > > The precise part about it is: > > " >> >> When there is no -w or -b, the lists are taken from >> /etc/cgsnapshot.{white,black}list. If there is no such file, the >> appropriate >> list is empty. User could erase these default lists using e.g. '-b >> /dev/null' (=no extra code needed) or '-i' as '--ignore-default-lists'. >> > > I am not so sure I want a default blacklist. But I can see where you > are coming from, and do not have a strong objection to it. > > "
default blacklist :-). not a whitelist. Sorry for not having been clearer, but as I mentioned in http://article.gmane.org/gmane.comp.lib.libcg.devel/2304 , I still hold the view that having a default whitelist is unmaintainable. So, let's not have that please! > I want to implement "-i" option later when the present version of tool will > be merged not to have too big patchset for the review. Thanks, Dhaval ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
