On 11/12/2010 11:41 AM, Dhaval Giani wrote: > Hi, > > So looking at https://bugzilla.redhat.com/show_bug.cgi?id=652583, I > was wondering if there is any rationale in having > > error = rmdir(mount_info->path); > if (error) { > last_errno = errno; > ret = ECGOTHER; > } > > in src/config.c ? > > Now git blame blames me for introducing that code. I cannot see any > rationale of having it, so if everyone is fine with it, I propose to > just nuke those lines. Counter use-cases will be great! (I think I put > it there since cgconfigparser has the ability to mkdir the mount > points) > > Thanks! > Dhaval I agree with the removing. E.g. because if there are more mount points then the problematic one, then cgclear will stop the removing after the problematic one and leaves the rest there. Then it is necessary to use cgclear multiple times.
Ivana ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
