Hi! On Mon, Nov 15, 2010 at 9:52 AM, Jan Safranek <[email protected]> wrote: > Forwarding to the list... > > -------- Original Message -------- > Subject: libcgroup code review > Date: Fri, 12 Nov 2010 14:55:48 -0500 > From: Steve Grubb <[email protected]> > To: [email protected] > > Hello, > > I see that you are doing commits to upstream code on sourceforge. Below > I have the > results of a code review. This is against whatever was in the fedora > master branch. >
Ah, that is quite old, and does not really match the upstream code perfectly, so, > -Steve > > > In src/api.c > *At line 196, there is a return without freeing tmp_string. > *At line 637, is a return without freeing newrule. For this one, I would > suggest > setting newrule to NULL after assigning it to the linked list. This way > you can have a > free after the close label. > *At line 2131 is a for loop that re-uses the index variable of the for > loop at 2122. > Should there be 2 variables one for each loop? > *At line 2566 ret is checked to see if its not 3. The test for EOF is > not needed > because EOF is -1 which is not 3. > *At line 2749 is a return without freeing "entry". > *At line 3192 len=0; is never executed. All paths lead to a continue or > a break. > if you don't mind, some context around these lines mentioned here or line numbers from upstream will be so awesome and ensure I am fixing the right places! Thanks! Dhaval ------------------------------------------------------------------------------ Centralized Desktop Delivery: Dell and VMware Reference Architecture Simplifying enterprise desktop deployment and management using Dell EqualLogic storage and VMware View: A highly scalable, end-to-end client virtualization framework. Read more! http://p.sf.net/sfu/dell-eql-dev2dev _______________________________________________ Libcg-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libcg-devel
