On Tue, Nov 16, 2010 at 12:11 PM, Jan Safranek <[email protected]> wrote:
> Add missing return value assignment, as pointed out by Steve Grubb.
>
>
> Changelog:
> - indent the 'if (ret)' lower.
>
> Signed-off-by: Jan Safranek <[email protected]>

Acked-by: Dhaval Giani <[email protected]>

> ---
>
>  src/tools/cgget.c |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/src/tools/cgget.c b/src/tools/cgget.c
> index aad222a..1d3ad55 100644
> --- a/src/tools/cgget.c
> +++ b/src/tools/cgget.c
> @@ -384,10 +384,12 @@ int main(int argc, char *argv[])
>                if (ret)
>                        goto err;
>
> -               if (mode & MODE_SHOW_ALL_CONTROLLERS)
> -                       display_all_controllers(argv[i], argv[0], mode);
> -               if (ret)
> -                       result = ret;
> +               if (mode & MODE_SHOW_ALL_CONTROLLERS) {
> +                       ret = display_all_controllers(argv[i], argv[0], mode);
> +                       /* remember the error but continue showing the rest */
> +                       if (ret)
> +                               result = ret;
> +               }
>
>                /* Separate each group with empty line. */
>                if (mode & MODE_SHOW_HEADERS && i != argc-1)

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to