On 11/19/2010 04:14 PM, Ivana Hutarova Varekova wrote:
> There is a bogus test in cgroup_get_parent_name
> which returns error in situation when 0 should be return.
> This causes problem e.g. when a hierarchy is mounted to two
> mount points.
>
> EXAMPLE:
>
> $ cat aux.conf
> mount {
> cpu = /cgroup/cpu;
> cpuacct = /cgroup/cpu;
> memory = /cgroup/memory;
> }
> group hXAjiy/wWRq {
> cpu {}
> memory {}
> }
> $ mkdir /mnt/cgroups/cpu 2>/dev/null
> $ mount -t cgroup -o cpu,cpuacct cpu /mnt/cgroups/cpu
> $ time cgconfigparser -l aux.conf
> $ cgclear
> $ cat /proc/cgroups
>
> OLD output
> #subsys_name hierarchy num_cgroups enabled
> cpuset 0 1 1
> ns 0 1 1
> cpu 301 1 1
> cpuacct 301 1 1
> memory 303 3 1
> devices 0 1 1
> freezer 0 1 1
> net_cls 0 1 1
> blkio 0 1 1
>
> New output
> #subsys_name hierarchy num_cgroups enabled
> cpuset 0 1 1
> ns 0 1 1
> cpu 0 1 1
> cpuacct 0 1 1
> memory 0 1 1
> devices 0 1 1
> freezer 0 1 1
> net_cls 0 1 1
> blkio 0 1 1
>
>
>
> Signed-off-by: Ivana Hutarova Varekova<[email protected]>
> ---
>
> 0 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/src/api.c b/src/api.c
> index a51230b..99cc5bc 100644
> --- a/src/api.c
> +++ b/src/api.c
> @@ -1515,9 +1515,6 @@ static int cgroup_get_parent_name(struct cgroup
> *cgroup, char **parent)
> }
> free(dir);
>
> - if (*parent == NULL)
> - ret = ECGFAIL;
> -
IMHO this code should not be just removed, but moved to
*parent=strdup(pdir); branch few lines above instead. If strdup fails,
it's certainly an error.
> return ret;
> }
>
>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2& L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today
> http://p.sf.net/sfu/msIE9-sfdev2dev
> _______________________________________________
> Libcg-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
>
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
