* torbenh <[email protected]> [2010-12-19 13:35:03]:
> > >
> > > # support multiple mount points
> > > declare -a MOUNTPOINT
> > > @@ -120,13 +121,24 @@ start() {
> > > return 6
> > > fi
> > >
> > > - $CGCONFIGPARSER_BIN -l $CONFIG_FILE
> > > - retval=$?
> > > - if [ $retval -ne 0 ]
> > > - then
> > > - log_failure_msg "Failed to parse " $CONFIG_FILE
> > > - return 1
> > > - fi
> > > + if [ -d $CONFIG_DIR ]
> > > + then
> > > + cat $CONFIG_FILE $CONFIG_DIR/* | $CGCONFIGPARSER_BIN -l
> > > -
> >
> > If configuration parsing fails for a particular file, it would get
> > confusing, since the parser will report the error as being a stdin
> > error. Why can't we loop through the files and explictly invoke
> > cgconfigparser?
>
> this would be the better solution.
> i just had problems with cgconfigparser being invoked multiple times
> with small snippets of the config.
>
True, but I would treat it as a one time cost, unloading is directly
from the filesystem, so that should still be fast.
> basically the small snippets which would get dumped into the config dir
> dont have the mount lines. (so this approach sort of failed)
>
Why did it fail?
> this patch is just an RFC patch, to just show what i am after ;)
>
> if we cant get multiple invocations of cgconfigparser to work,
> maybe just providing the configfiles to be read on the commandline would
> also work ?
>
> cgconfigparser $CONFIG_DIR/*
Or
for file in $CONFIG_DIR/*
do
cgconfigparser -l $file
done
>
>
> >
> > > + retval = $?
> > > + if [ $retval -ne 0 ]
> > > + then
> > > + log_failure_msg "Failed to parse " $CONFIG_FILE "
> > > and " $CONFIG_DIR
> > > + return 1
> > > + fi
> > > + else
^^^ else here
> >
> > But why does this have to be else, can't we have both?
>
> it also catted $CONFIG_FILE ... its not else :)
Oh! did I misread it, I saw an else (see above)
>
> cat $CONFIG_FILE $CONFIG_DIR/* | $CGCONFIGPARSER_BIN -l -
> >
> > > + $CGCONFIGPARSER_BIN -l $CONFIG_FILE
> > > + retval=$?
> > > + if [ $retval -ne 0 ]
> > > + then
> > > + log_failure_msg "Failed to parse " $CONFIG_FILE
> > > + return 1
> > > + fi
> > > + fi
> > > fi
> > >
> > > if [ $CREATE_DEFAULT == "yes" ]; then
> > > --
> > > 1.7.2.3
> > >
> > >
> > > ------------------------------------------------------------------------------
> > > Lotusphere 2011
> > > Register now for Lotusphere 2011 and learn how
> > > to connect the dots, take your collaborative environment
> > > to the next level, and enter the era of Social Business.
> > > http://p.sf.net/sfu/lotusphere-d2d
> > > _______________________________________________
> > > Libcg-devel mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/libcg-devel
> >
> > --
> > Three Cheers,
> > Balbir
>
> --
> torben Hohn
>
> ------------------------------------------------------------------------------
> Lotusphere 2011
> Register now for Lotusphere 2011 and learn how
> to connect the dots, take your collaborative environment
> to the next level, and enter the era of Social Business.
> http://p.sf.net/sfu/lotusphere-d2d
> _______________________________________________
> Libcg-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
--
Three Cheers,
Balbir
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Libcg-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libcg-devel
