* Jan Safranek <jsafr...@redhat.com> [2010-12-21 12:25:00]:
> On 12/21/2010 12:12 PM, Torben Hohn wrote:
> > this allows packages to create cgroups by just dumping files into
> > this directory.
> > packagers need to look out for naming conflicts themselves, but
> > not many packages are going to use this in the near future, so
> > this is is probably not so bad.
> >
> > Signed-off-by:Torben Hohn<torb...@gmx.de>
> Acked-by: Jan Safranek <jsafr...@redhat.com>
>
> This is a good start. On the long run it would be nice to
> 1) add some documentation,
> 2) update the spec file to add the new directory,
> 3) (maybe) move all config files to /etc/libcgroup/ so we don't pollute /etc
> 4) don't do this in initscript but in cgconfigparser using new
> 'include=/etc/cgconfig.conf.d/*' statement (I know Dhaval is working on
> this...).
>
> I'll do 2) eventually.
>
I think these are good suggestions and I'd rather that we do them now,
since they are straight forward. I am not for (4) very much, it
provides no value, let the shell handle includes and files.
So, if we are going to roll this out, lets get 1 to 3 done by 0.38
> Jan
>
> > ---
> > scripts/init.d/cgconfig.in | 13 +++++++++++++
> > 1 files changed, 13 insertions(+), 0 deletions(-)
> >
> > diff --git a/scripts/init.d/cgconfig.in b/scripts/init.d/cgconfig.in
> > index 0b3afd2..476dc7b 100644
> > --- a/scripts/init.d/cgconfig.in
> > +++ b/scripts/init.d/cgconfig.in
> > @@ -34,6 +34,7 @@
> > pref...@prefix@;exec_pref...@exec_prefix@;sbind...@sbindir@
> > CGCONFIGPARSER_BIN=$sbindir/cgconfigparser
> > CGROUP_FS=cgroup
> > CONFIG_FILE=/etc/cgconfig.conf
> > +CONFIG_DIR=/etc/cgconfig.conf.d
> >
> > # support multiple mount points
> > declare -a MOUNTPOINT
> > @@ -127,6 +128,18 @@ start() {
> > log_failure_msg "Failed to parse " $CONFIG_FILE
> > return 1
> > fi
> > +
> > + if [ -d $CONFIG_DIR ]
> > + then
> > + for config in $CONFIG_DIR/*; do
> > + $CGCONFIGPARSER_BIN -l $config
> > + retval = $?
> > + if [ $retval -ne 0 ]
> > + then
> > + log_failure_msg "Failed to parse "
> > $config
> > + fi
> > + done
> > + fi
> > fi
> >
> > if [ $CREATE_DEFAULT == "yes" ]; then
>
>
> ------------------------------------------------------------------------------
> Lotusphere 2011
> Register now for Lotusphere 2011 and learn how
> to connect the dots, take your collaborative environment
> to the next level, and enter the era of Social Business.
> http://p.sf.net/sfu/lotusphere-d2d
> _______________________________________________
> Libcg-devel mailing list
> Libcg-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libcg-devel
--
Three Cheers,
Balbir
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
