On Thu, Jan 27, 2011 at 6:49 PM, Jan Safranek <jsafr...@redhat.com> wrote: > On 01/25/2011 05:48 AM, Balbir Singh wrote: >> * Ivana Varekova<varek...@redhat.com> [2011-01-24 16:30:50]: >> >>> This patchset contains a script which provides general functions and >>> variables and a firts test which uses it. >>> >> >> Ivana >> >> The changelog is poor and does not indicate what the series attempts. >> How does this fit in with the current test suite, what are the short >> comings of that suite. > > The old suite tests libcgroup *API*, the new one tests the *tools*. We > have some more tests prepared, this is just a first sample for review.
I looked at the scripts and saw a lot of hard coding and mounting. In our runlibcgrouptest.sh, we have something like DEBUG=false; # for debug messages FS_MOUNTED=0; # 0 for not mounted, 1 for mounted, 2 for multimounted MOUNTPOINT=/dev/cgroup_controllers; # Just to initialize TARGET=/dev/cgroup_controllers; CONTROLLERS=cpu,memory; NUM_MOUNT=1; # Number of places to be mounted on MULTIMOUNT=false; # mounted at one point only NUM_CTLRS=0; # num of controllers supported CTLR1=""; CTLR2=""; CPU=""; MEMORY=""; SKIP_TEST=77 RET=0 Not the best, but at-least it is readable. Ideally we need a config file, but I am not going to insist on it, need to see readable test cases Balbir ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
