On Wed, Feb 23, 2011 at 12:44:48PM +0100, Jan Safranek wrote:
> On 02/23/2011 12:24 AM, James M Leddy wrote:
> > We set disjoint cpu sets with the following command:
> > 
> > cgset -r cpuset.cpus=0,2 slot1
> > 
> > However, we don't allow commas that as part of the grammar when used
> > in the configuration file at cgconfig.conf. This patch seeks to
> > address that.
> 
> If you notice one line below your change, you can specify cpus even now,
> enclosed in double quotes like cpuset.cpus="0,2". But adding comma to
> list of allowed characters won't harm.

Ah I hadn't seen that because I was working with an older version. I
still suspect some users will be confused without quotes when 0-2
works and 0,2 does. Thanks for your help.
> 
> Jan
> 
> > ---
> >  src/lex.l |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/src/lex.l b/src/lex.l
> > index a80327c..d590e9f 100644
> > --- a/src/lex.l
> > +++ b/src/lex.l
> > @@ -32,7 +32,7 @@ int line_no = 1;
> >  "perm"             {return PERM;}
> >  "group"            {return GROUP;}
> >  "namespace"        {return NAMESPACE;}
> > -[a-zA-Z0-9_\-\/\.]+ {yylval.name = strdup(yytext); return ID;}
> > +[a-zA-Z0-9_\-\/\.\,]+ {yylval.name = strdup(yytext); return ID;}
> >  \"[^"]*\" {yylval.name = strdup(yytext+1); 
> > yylval.name[strlen(yylval.name)-1] = '\0'; return ID; }
> >  .  {return yytext[0];}
> >  %%
> 

-- 
James M. Leddy
Technical Account Manager
Red Hat Inc.
work: 212-510-4119
cell: 631-891-8703

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to