On 03/04/2011 02:51 PM, Dhaval Giani wrote: > On Fri, Mar 4, 2011 at 1:06 PM, Jan Safranek<jsafr...@redhat.com> wrote: >> Currently when the cgclear stumbles upon a mount point which cannot be >> removed it exits immediatelly. IMHO it should continue clearing the rest >> and unmount as much as possible. >> >> >> Signed-off-by: Jan Safranek<jsafr...@redhat.com> > > Acked-by: Dhaval Giani<dhaval.gi...@gmail.com>
I merged this one, thanks for review. Jan > >> --- >> >> src/config.c | 13 +++++++------ >> 1 files changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/src/config.c b/src/config.c >> index 23e1e43..0f71003 100644 >> --- a/src/config.c >> +++ b/src/config.c >> @@ -780,8 +780,6 @@ int cgroup_unload_cgroups(void) >> } >> >> error = cgroup_get_controller_begin(&ctrl_handle,&info); >> - >> - >> if (error&& error != ECGEOF) { >> ret = error; >> goto out_error; >> @@ -796,10 +794,13 @@ int cgroup_unload_cgroups(void) >> if (!curr_path) >> goto out_errno; >> >> - ret = cgroup_config_unload_controller(&info); >> - >> - if (ret) >> - goto out_error; >> + error = cgroup_config_unload_controller(&info); >> + if (error) { >> + /* remember the error and continue unloading >> + * the rest */ >> + ret = error; >> + error = 0; >> + } >> } >> >> error = cgroup_get_controller_next(&ctrl_handle,&info); >> >> >> ------------------------------------------------------------------------------ >> What You Don't Know About Data Connectivity CAN Hurt You >> This paper provides an overview of data connectivity, details >> its effect on application quality, and explores various alternative >> solutions. http://p.sf.net/sfu/progress-d2d >> _______________________________________________ >> Libcg-devel mailing list >> Libcg-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/libcg-devel >> > > ------------------------------------------------------------------------------ > What You Don't Know About Data Connectivity CAN Hurt You > This paper provides an overview of data connectivity, details > its effect on application quality, and explores various alternative > solutions. http://p.sf.net/sfu/progress-d2d > _______________________________________________ > Libcg-devel mailing list > Libcg-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libcg-devel ------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel