* Jan Safranek <jsafr...@redhat.com> [2011-05-12 10:44:59]:
> On 05/12/2011 10:41 AM, Balbir Singh wrote:
> > * Jan Safranek <jsafr...@redhat.com> [2011-05-12 08:57:33]:
> >
> >> I tried to reconstruct libcgroup logging. Currently we log to stdout and
> >> only
> >> if --enable-debug is specifed on configure command line.
> >>
> >> With this patchset, libcgroup ends up with:
> >> - multiple log levels of messages.
> >> - logging to stdout by default (!), but only errors and warnings go there.
> >> -> our tools (cgcreate, cgconfigparser, ...) log errors/warnings to
> >> stdout
> >> by default.
> >> -> the log level can be easily controller by CGROUP_LOGLEVEL environment
> >> variable (e.g. to print debug messages during development or to
> >> create
> >> proper error report). I might eventually add -v and -q options for
> >> more
> >> vebose/quiet tools.
> >> - applications can set their own callback to put log messages to syslog,
> >> log
> >> file, gui window or just where they want and they can specify level of
> >> messages they want to receive.
> >> - all is documented, both for application developers in doxygen and for
> >> users
> >> in man pages.
> >>
> >
> > Thanks for the cleanup, I read through and most of the patches seem
> > good. I have some quick questions
> >
> > 1. I see cgroup_err, warn, etc defined in patch 10/13, but I see them
> > used before in patch 7/13. Am I missing something?
>
> They are defined in 2/13 in libcgroup-internal.h for libcgroup itself
> and in 10/13 for tools, which do not include libcgroup-internal.h
>
I can see them thanks!
> > 2. Is there a reason to still keep flog() around?
> > 3. I don't see where cgroup log messages are sent to syslog
>
> libcgroup just provides possibility to set a logging callback, it's up
> to applications (=cgrulesengd) to send the message to syslog. And that's
> what flog() does. I've been probably not specific enough in the patch
> descriptions.
Yes, the description in the flog changes lead me to believe we are
logging everything to syslog (even cgroup_err, etc).
--
Three Cheers,
Balbir
------------------------------------------------------------------------------
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel
