On Fri 20-05-11 14:29:58, Jan Safranek wrote: > On 05/19/2011 09:39 PM, Michal Hocko wrote: [...] > > @@ -523,13 +523,11 @@ int cgroup_get_procs(char *name, char *controller, > > pid_t **pids, int *size); > > /** > > * Change permission of files and directories of given group > > * @param cgroup The cgroup which permissions should be changed > > - * @param dir_mode The permission mode of group directory > > - * @param dirm_change Denotes whether the directory change should be done > > - * @param file_mode The permission mode of group files > > - * @param filem_change Denotes whether the directory change should be done > > + * @param dir_mode The permission mode of group directory (-1 for no > > change) > > + * @param file_mode The permission mode of group files (-1 for no change) > > */ > > int cg_chmod_recursive(struct cgroup *cgroup, mode_t dir_mode, > > - int dirm_change, mode_t file_mode, int filem_change); > > + mode_t file_mode); > > NACK, this changes ABI!
Yes, I am aware of that. > As I commented in previous patch, please make new function. *Sigh* :(. I do not care much. It is probably not worth it. I will drop it. But, hey, I had to at least try ;) How many external users does the library have? My impression was that only tools that are maintained with it are users... Then the ABI wouldn't hurt that much. > > Otherwise, all 4 patches are very well written, keep up the good work! Thanks. Will repost cleaned up series. -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
