On Wed 25-05-11 15:30:16, Dhaval Giani wrote: > On Fri, May 20, 2011 at 4:42 PM, Michal Hocko <mho...@suse.cz> wrote: > > On Fri 20-05-11 16:41:27, Michal Hocko wrote: > >> On Fri 20-05-11 14:25:17, Jan Safranek wrote: > >> > On 05/19/2011 09:37 PM, Michal Hocko wrote: > >> > > There is no general rule on which permissions make sense for files in > >> > > different subsystems. Nevertheless the kernel creates those files with > >> > > the maximum allowed permissions for owner so we should use its part as > >> > > an umask for group and others permissions as well. > >> > > This means that if we specify 777 for file_mode we will end up having > >> > > same permissions as owner what ever they are. > >> > > >> > NACK, this will change semantics of public function > >> > cg_chmod_recursive(). I know, it's stupid copy/paste, but please create > >> > new function cg_copymod_recursive (or cpmod or whatever) :( > >> > >> What about this? > > > > I am not able to link with this patch because of the prelink magic: > > cgcreate.o: In function `main': > > /mnt/share/devel/miso/libcg/src/tools/cgcreate.c:314: undefined reference > > to `cg_owner_mask_chmod_recursive' > > collect2: ld returned 1 exit status > > > > How should I do this properly? > > I missed this email. Let me take a look at the patches, and suggest > something. Though Jan is the resident expert of Makefile magic :)
I was about to copy&paste what is done for cg_chmod_recursive but then I thought that there might be some generator for that... -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
