On 05/25/2011 04:06 PM, Dhaval Giani wrote: > On Wed, May 25, 2011 at 3:35 PM, Jan Safranek <jsafr...@redhat.com> wrote: >> On 05/25/2011 03:28 PM, Dhaval Giani wrote: >>> On Fri, May 20, 2011 at 3:52 PM, Jan Safranek <jsafr...@redhat.com> wrote: >>>> Ivana had some remarks on code reability... so there is third version of >>>> this >>>> simple patchset. I hope that's the final one :). >>>> >>>> Changelog since last version: >>>> - reworked the if conditions to be less confusing >>> >>> OK, so i don't like this fix too much :D. Does this make things better >>> in terms of behavior in terms of unmounting cgroups, and now let's fix >>> systemd? (I will add a changelog a while later if people agree with >>> this fix. I think it is quite obvious, but...) >> >> >> I'd like the cgconfigparser clean up at least what it mounted. I have >> half-baked patch for that. Anyway, empty cgconfig.conf can be supported >> too, can't it? >> > > That is exactly what this patch does.
Oh, I missed the global config_table_index variable. It looks really too ugly to me, I don't like it at all. I might pretend I do not see the patch in git if there is big exclamation mark and comment like 'this is for cgroup_config_unmount_controllers() not to unmount anything we did not mounted'. Jan ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
