On Fri 27-05-11 14:21:25, Jan Safranek wrote: [...] > I know, probably you did not know, but we use kernel's checkpatch script > for code style checking of libcgroup sources. And the script complains a > bit: > > WARNING: externs should be avoided in .c files > #45: FILE: src/config.c:75: > +void init_cgroup_table(struct cgroup *cgroups, size_t count);
This is just a fwd. declaration to prevent from exporting init_cgroup_table (which is quite internal from my POV). > WARNING: line over 80 characters > #96: FILE: src/wrapper.c:28: > + cgroup->task_fperm = cgroup->control_fperm = > cgroup->control_dperm = NO_PERMS; Does it really make sense to follow 80 chars rule here? If you want to grep for NO_PERMS then it is nicer to have all those initialized values at the same line. Or I could just make it separately for evert *perm per line. I do not care much but having it at one line is IMHO more intuitive. > > (well, you can ignore -ECGFAIL warning, I wonder how to turn it off) > > Apart from few checkpatch problems, the patch looks fine. Thanks for review. [...] -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
