On Wed, Jun 8, 2011 at 8:23 AM, Michal Hocko <mho...@suse.cz> wrote: > On Wed 08-06-11 16:40:42, Jan Safranek wrote: >> On 06/07/2011 03:56 PM, Michal Hocko wrote: > [...] >> The patchset looks pretty well, see individual comments in separate > > Thanks for the review. > >> mails, but I still can see lot of checkpatch complaints: >> >> WARNING: externs should be avoided in .c files >> #47: FILE: src/config.c:75: >> +void init_cgroup_table(struct cgroup *cgroups, size_t count); >> >> That should go to libcgroup-internal.h > > Moved > >> >> WARNING: line over 80 characters >> #98: FILE: src/wrapper.c:28: >> + cgroup->task_fperm = cgroup->control_fperm = >> cgroup->control_dperm = NO_PERMS; >> >> Well.. I am inclined to break 80 char. limit, I've never understood what >> is it good for. What about Dhaval's opinion?
Yeah, I agree. Let;s break it here. Dhaval ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Libcg-devel mailing list Libcg-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libcg-devel
