On Fri 17-06-11 10:33:45, Jan Safranek wrote:
> When cgroup_create_cgroup() is called with different control_fperm and
> task_fperm, libcgroup first changes permissions of *all* files to match
> the control_fperm, which includes the also the tasks file and it might
> loose some permission bits. The tasks file is then modulated by
> control_fperm, but because umask-style of control_fperm, it might get
> lower permissions that users would expect.
> 
> Therefore 'tasks' file must be skipped when using control_fperm.
> 
> Changelog since v1:
>   - use list of ignored files, cg_chmod_recursive_controller is called from
>     cg_chmod_recursive, which should chmod all files, incl. 'tasks'.
> 
> Changelog since v2:
>   - renamed the list with ignored files.
> 
> Signed-off-by: Jan Safranek <jsafr...@redhat.com>

Reviewed-by: Michal Hocko <mho...@suse.cz>

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Libcg-devel mailing list
Libcg-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libcg-devel

Reply via email to